Do not mark AbstractQuery as internal #10641
Conversation
adn keep it as an SPI, since it is extended in Hibernate Search
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
|
Honestly I think the best way forward here is for Search to stop relying on these implementation classes, which, quite frankly, aren't sufficiently stable across releases to be legitimately treated as SPIs. Surely there's some way for Search to eliminate this dependence. I know |
|
hmm ok ... hey @yrodiere , so with that ^ do you think I should just deprecate the |
Fine by me. It was mostly useful for people migrating from Hibernate Search 5.x, where ORM's |
|
(And it probably means the 5.x migration helpers should disappear in Search 9.x too, since they absolutely need |
|
Thanks, I'll deprecate things in Search then; and close this PR 👍🏻 |
3 participants
and keep it as an SPI, since it is extended in Hibernate Search.
I've reverted the change just for the
AbstractQuery, but since it extends the others, do we keep them as SPI too (i.e. should I revert that entire commit or just this one class?)See
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.